Draft
Conversation
post() checks the value of the WHOAMI register against the constant IMU device ID
post() will run the post functions of subsystems to ensure they exist and can be communicated with currently just calls the IMU post function
JohanneMontano
requested changes
Feb 19, 2026
Comment on lines
+111
to
+115
| if (who_am_i != IMU_DEVICE_ID) { | ||
| return false; | ||
| } | ||
|
|
||
| return true; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (who_am_i != IMU_DEVICE_ID) { | |
| return false; | |
| } | |
| return true; | |
| return who_am_i == IMU_DEVICE_ID |
Comment on lines
+91
to
+94
| bool posted_successfully = nusenseIO.post(); | ||
| if (!posted_successfully) { | ||
| return -1; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| bool posted_successfully = nusenseIO.post(); | |
| if (!posted_successfully) { | |
| return -1; | |
| } | |
| bool posted_successfully = nusenseIO.post(); | |
| if (!posted_successfully) { | |
| // Insert a better tracker | |
| } |
You wouldnt want to just return -1 here in main, itd be useful to have an actual error message. Try using the buzzer or something else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement POSTs for NUSenseIO and any subsystems we can implement a POST for (currently just the IMU).
Currently: